Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak os prober test #83894

Merged
merged 2 commits into from Mar 31, 2020
Merged

Unbreak os prober test #83894

merged 2 commits into from Mar 31, 2020

Conversation

symphorien
Copy link
Member

Motivation for this change

Unbreak os-prober test. I had to disable documentation to prevent OOM.

Fixes #77396 #80041

CC @Ekleog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ekleog
Copy link
Member

Ekleog commented Mar 31, 2020

@ofborg build nixosTests.os-prober

@Ekleog Ekleog merged commit a3ee24b into NixOS:master Mar 31, 2020
@worldofpeace
Copy link
Contributor

@symphorien This is an issue on stable? If so, we should backport it.

@symphorien
Copy link
Member Author

probably, yes, but it's only a test, not a real package.

@Ekleog
Copy link
Member

Ekleog commented Mar 31, 2020

Well, technically the first commit also fixes issues on stable, and it's always nice to have the test fixed on stable so we could more easily run it should an os-prober change need to be backported, so I've just backported as fe6052f and f1fcd30 for 20.03 :) Thank you for the heads' up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debian url source in vmTools yields 404
3 participants