Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lilyterm: 2017-01-06 -> 2019-07-25 #83895

Merged
merged 1 commit into from Apr 2, 2020
Merged

lilyterm: 2017-01-06 -> 2019-07-25 #83895

merged 1 commit into from Apr 2, 2020

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Mar 31, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Profpatsch April 1, 2020 03:04
@AndersonTorres @Profpatsch
lilyterm: 2017-01-06 -> 2019-07-25
1eb32b5 
faf1254f46049edfb1fd6e9191e78b1b23b9c51d
  Fix a segfault bug for vte-0.54
@Profpatsch
Copy link
Member

Added a bit of changelog to the commit description, LGTM

@Profpatsch Profpatsch merged commit a4e96ca into NixOS:master Apr 2, 2020
@AndersonTorres AndersonTorres deleted the update-lilyterm branch November 30, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndersonTorres @Profpatsch @grahamc