Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matterhorn: fix build #83879

Merged
merged 1 commit into from Apr 1, 2020
Merged

matterhorn: fix build #83879

merged 1 commit into from Apr 1, 2020

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Mar 31, 2020

also fixes mattermost-api, mattermost-api-qc,
and adds them to stewardship by kiwi

Motivation for this change

it was broken and now it's not broken

Things done

fixed it

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Kiwi
matterhorn: fix build
43c578c 
also fixes mattermost-api, mattermost-api-qc,
and adds them to stewardship by kiwi
@cdepillabout
Copy link
Member

LGTM, thanks for updating this!

@cdepillabout cdepillabout merged commit eac1abc into NixOS:haskell-updates Apr 1, 2020
@cdepillabout
Copy link
Member

I imagine some of the dependencies of matterhorn are in stackage, and some aren't, which is causing the problems you fixed here.

If you want to get all the non-stackage packages into stackage, that would help not having to fix this stuff in the future in nixpkgs. Most things should "just work" in nixpkgs as long as the package is in stackage.

@Kiwi Kiwi deleted the matterhorn branch August 18, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kiwi @cdepillabout