Throws an error when I try to run it:

nix-shell:~/.cache/nixpkgs-review/pr-83905/results/ursadb/bin]$ ./ursadb_new ~/tmp/mydb

[nix-shell:~/.cache/nixpkgs-review/pr-83905/results/ursadb/bin]$ ./ursadb ~/tmp/mydb 2048
terminate called after throwing an instance of 'zmq::error_t'
  what():  Invalid argument
Aborted (core dumped)

Hi,

thanks for input, If I knew anyone will test it I'd add more detailed instructions .

Looks like you've addded one parameter too much (if you want to specify the bind address you can do it like tcp://127.0.0.1:9281 - the error message could've been clearer i guess).

msm@scourge ~/P/nixpkgs> nix-build -A ursadb
/nix/store/8xlnxlm8q8y5bilzwkxviaxzi8cgya1h-ursadb
msm@scourge ~/P/nixpkgs> ./result/bin/ursadb_new /tmp/ursa/test.db
msm@scourge ~/P/nixpkgs> ./result/bin/ursadb /tmp/ursa/test.db

And there should be a process listening on :9281 (default bind address)

I use https://github.com/CERT-Polska/ursadb-cli and https://github.com/CERT-Polska/mquery for testing (and on production), though they're not on nixpkgs (yet?).

Hi,

thanks for input, If I knew anyone will test it I'd add more detailed instructions .

Looks like you've addded one parameter too much (if you want to specify the bind address you can do it like tcp://127.0.0.1:9281 - the error message could've been clearer i guess).

msm@scourge ~/P/nixpkgs> nix-build -A ursadb
/nix/store/8xlnxlm8q8y5bilzwkxviaxzi8cgya1h-ursadb
msm@scourge ~/P/nixpkgs> ./result/bin/ursadb_new /tmp/ursa/test.db
msm@scourge ~/P/nixpkgs> ./result/bin/ursadb /tmp/ursa/test.db

And there should be a process listening on :9281

Indeed, somehow I got [bind_address] confused with [socket] and supplied only a number. With your instructions it starts correctly.

I use https://github.com/CERT-Polska/ursadb-cli and https://github.com/CERT-Polska/mquery for testing (and on production), though they're not on nixpkgs (yet?).

Future packaging opportunity? 😁

Future packaging opportunity?

I'm very much happy to to this in the future (though this service is the core so prerequisite for the others).

Maybe not ursadb-cli (I've noticed python package maintainers don't like too niche packages due to maintenance burden), but certainly mquery (right now the only supported installation method is docker, which is very meh).

Would you kindly squash down the review commits into the init at commit? Than this should be ready to go.

Thanks for your suggestions! The url thing was accidental, I didn't even know that I can have strings without quotes (I assumed that quotes make a string, no quotes but slash == path, variable otherwise).

Sure, I was not sure if I was supposed to squash it or leave as it is

Sure, I was not sure if I was supposed to squash it or leave as it is

The submission guidelines mention that review fixes should be squashed.

You're right, I missed that. FWIW I squashed my changes before the first push. Thanks for clarifying!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/135

Result of nixpkgs-review pr 83905 1