Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diffr: 0.1.2 -> 0.1.4 #83866

Merged
merged 1 commit into from Mar 31, 2020
Merged

diffr: 0.1.2 -> 0.1.4 #83866

merged 1 commit into from Mar 31, 2020

Conversation

davidtwco
Copy link
Member

Motivation for this change

Update to most recent release of diffr.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jollheef
jollheef approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@jollheef jollheef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Tested on NixOS

@Mic92 Mic92 merged commit 61666e0 into NixOS:master Mar 31, 2020
@davidtwco davidtwco deleted the diffr-0.1.4 branch June 14, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@jollheef jollheef jollheef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidtwco @Mic92 @jollheef