whirlpool-gui: init at 0.10.1 #83851
Conversation
|
deps.nix contain quite a lot of dependencies, which results in 300k text file. I could use dynamic generation from |
|
is there a way to use a yarn.lock and just have a vendor hash? cc @bhipple |
|
It is possible with recursive nix, but I am unsure how to do it only using yarn, as cache it produces seems to be non-deterministic. Maybe I can just package binary for now, and later when we find better solution, can build from source. |
|
|
||
| meta = { | ||
| description = "Desktop GUI for Whirlpool by Samourai-Wallet"; | ||
| homepage = https://www.samouraiwallet.com/whirlpool; |
| # install build dependencies and patch shebangs | ||
| yarn install --offline --frozen-lockfile --ignore-scripts --no-progress --non-interactive | ||
| patchShebangs node_modules/ | ||
| ''; |
There was a problem hiding this comment.
Surely there are other yarn packages in Nix that have a well established pattern for this, and we don't need to re-implement it ourselves?
I'd take a look at mkYarnPackage and see if it can do what you need, like this one does:
There was a problem hiding this comment.
I have tried and it does not fit this package, as I just need to build statics and install only production dependencies
|
I will close this pull request and package prebuild binary, as I do not think it is possible with current infrastructure to package this, without introducing thousands lines of generated code. If someone else has any idea can replace later. |
Motivation for this change
Add
whirlpool-guiclient, chaumian coinjoin bitcoin implementation, which can be used withsamuraibitcoin wallet for extra privacy.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)