Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nano: 4.9 -> 4.9.1 #83883

Merged
merged 1 commit into from Mar 31, 2020
Merged

nano: 4.9 -> 4.9.1 #83883

merged 1 commit into from Mar 31, 2020

Conversation

lsix
Copy link
Member

@lsix lsix commented Mar 31, 2020

See https://lists.gnu.org/archive/html/info-gnu/2020-03/msg00015.html
for release information

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasj19
Copy link
Contributor

dasj19 commented Mar 31, 2020 •
edited

Output of nixpkgs-review pr 83883:

12 package updated:
cabal2nix crip cvs cvs-fast-export cvs2svn cvsps cvsq dep2nix-unstable nano (4.9 → 4.9.1) nix-prefetch-cvs nix-prefetch-scripts nix-update-source
12 package built:
cabal2nix crip cvs cvs2svn cvs_fast_export cvsps cvsq dep2nix nano nix-prefetch-cvs nix-prefetch-scripts nix-update-source

I don't have approve rights... otherwise I would approve it

jonringer
jonringer approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

https://github.com/NixOS/nixpkgs/pull/83883
12 package built:
cabal2nix crip cvs cvs2svn cvs_fast_export cvsps cvsq dep2nix nano nix-prefetch-cvs nix-prefetch-scripts nix-update-source

@jonringer jonringer merged commit 40fb6de into NixOS:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lsix @dasj19 @jonringer