Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #80461 from danieldk/ftfy-5.7 #80461

Merged
merged 1 commit into from Feb 18, 2020
Merged

Merge pull request #80461 from danieldk/ftfy-5.7 #80461

merged 1 commit into from Feb 18, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changelog:

https://github.com/LuminosoInsight/python-ftfy/blob/master/CHANGELOG.md#version-57-february-18-2020

The most important change in this version is the update of Unicode
character categories data to Unicode 12.1. This fixes the Python 3.8
build.

This was the only failing dependency for spaCy on Python 3.8. Tested
by loading a spaCy model and annotating a text.

Should probably also be backported for ZHF #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
python3Packages.ftfy: 5.6 -> 5.7
77aa1a7 
Changelog:

https://github.com/LuminosoInsight/python-ftfy/blob/master/CHANGELOG.md#version-57-february-18-2020

The most important change in this version is the update of Unicode
character categories data to Unicode 12.1. This fixes the Python 3.8
build.
@ofborg ofborg bot requested a review from aborsu February 18, 2020 19:06
@disassembler disassembler changed the title python3Packages.ftfy: 5.6 -> 5.7 Merge pull request #80461 from danieldk/ftfy-5.7 Feb 18, 2020
@disassembler disassembler merged commit fa7dcc7 into NixOS:master Feb 18, 2020
@danieldk danieldk deleted the ftfy-5.7 branch February 18, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@aborsu aborsu Awaiting requested review from aborsu

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @disassembler