Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ansible-runner: skip failing test on Catalina #80484

Merged
merged 2 commits into from Feb 19, 2020
Merged

pythonPackages.ansible-runner: skip failing test on Catalina #80484

merged 2 commits into from Feb 19, 2020

Conversation

kalbasit
Copy link
Member

Motivation for this change

Catalina replaced the director /home with a symbolic link to /System/Volumes/Data/home and this test is looking for /home explicitly.

I filed ansible/ansible-runner#413 to get this fix upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
pythonPackages.ansible-runner: skip failing test on Catalina
ecf6da9 
Catalina replaced the director /home with a symbolic link to
/System/Volumes/Data/home and this test is looking for /home
explicitly.

I filed ansible/ansible-runner#413 to get this fix upstream.
@ofborg ofborg bot requested a review from costrouc February 19, 2020 00:57
@kalbasit @jonringer
Update pkgs/development/python-modules/ansible-runner/default.nix
c61bb59 
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@kalbasit
Copy link
Member Author

It seems to work fine! I'm planning to squash-merge the pr so no need to rebase commits.

@GrahamcOfBorg build python2Packages.ansible-runner python3Packages.ansible-runner

@jonringer
Copy link
Contributor

otherwise LGTM

@kalbasit kalbasit merged commit f84bc72 into NixOS:master Feb 19, 2020
@kalbasit kalbasit deleted the nixpkgs_fix-python-ansible-runner-on-darwin branch February 19, 2020 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalbasit @jonringer