Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-web: add config overrides for privacy #80364

Merged
merged 1 commit into from Feb 17, 2020
Merged

riot-web: add config overrides for privacy #80364

merged 1 commit into from Feb 17, 2020

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Feb 17, 2020

Motivation for this change

Preventing the app from phoning home by default.

GitHub: closes #80358

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien
riot-web: add config overrides for privacy
c9e5cca 
Preventing the app from phoning home by default.

GitHub: closes NixOS#80358
rnhmjoj
rnhmjoj approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't know you could merge JSON like that with jq. I tested with

nix build -f. riot-web --arg overlays '[ (self: super: { riot-web = super.riot-web.override { conf = { disable_guests = true; }; }; })]'

and the generate configuration looks correct.

@rnhmjoj rnhmjoj merged commit 7429153 into NixOS:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

riot-web and riot-desktop are phoning home
3 participants
@pacien @rnhmjoj @Ma27