Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-geiger: fix build with rust 1.41 #80427

Merged
merged 1 commit into from Feb 18, 2020
Merged

cargo-geiger: fix build with rust 1.41 #80427

merged 1 commit into from Feb 18, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Feb 18, 2020 •
edited

Motivation for this change

ZHF: #80379

Things done

Also, ran cargo-geiger on actual Rust project (I picked https://gitlab.com/pastebinrun/pastebinrun, one of my Rust projects, because why not)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

evanjs
evanjs approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@evanjs evanjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work great!
Looks like we still need these tests disabled, but ah well.

Thanks!

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 18, 2020
@Ma27 Ma27 merged commit 3698ce1 into NixOS:master Feb 18, 2020
@Ma27
Copy link
Member

Ma27 commented Feb 18, 2020

Thanks! Backported as 7dde515.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanjs evanjs evanjs approved these changes

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KamilaBorowska @Ma27 @evanjs