Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update maintainer infos for myself #80425

Merged
merged 1 commit into from Feb 19, 2020
Merged

update maintainer infos for myself #80425

merged 1 commit into from Feb 19, 2020

Conversation

GRBurst
Copy link
Contributor

@GRBurst GRBurst commented Feb 18, 2020 •
edited

Motivation for this change

Update E-Mail and add GitHub Id and Keys to my maintainer infos.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Feb 18, 2020

Github, Github ID looks good. I don't know about the PGP key: you haven't uploaded it to a keyserver/github yet, right?

@GRBurst
Copy link
Contributor Author

GRBurst commented Feb 19, 2020

@rnhmjoj thanks for the fast response. I re-added the key right now because I added an uid. But I have not signed my commits, yet

@GRBurst
Copy link
Contributor Author

GRBurst commented Feb 19, 2020

@rnhmjoj Are there further steps necessary besides adding it to my github account? Do I have to upload it to a specific keyserver that nixpkgs uses for verification? Thanks for your help in advance :-)

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Feb 19, 2020 •
edited

I don't know of any hard requirement, it's just convenient: if you upload it to github everyone can quickly see the comit are signed, and a keyserver is useful to get your key if anyone want to send an email. I wanted to be sure you wrote the right key.

@rnhmjoj rnhmjoj merged commit 5f12d64 into NixOS:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GRBurst @rnhmjoj