python/aiohttp: disable test on 32bit platforms #80388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test `test_cookiejar` is failing because a time_t constant can't be represented on 32bit platforms.
|
@GrahamcOfBorg test login |
jonringer
approved these changes
Feb 18, 2020
|
ZHF: #80379 |
|
@jonringer This couldn't even been CI'd by ofborg because it's on i686-linux. |
|
merged based on diff, disabling a test is pretty harmless. |
|
Did you see if the NixOS test succeed? ofBorg apparently skipped i686-linux. |
|
the x86_64 test did succeed https://github.com/NixOS/nixpkgs/runs/451651746 |
Yeah doing that now. It is pretty harmless though, but it's to make the nixosTests succeed on i686-linux. Will backport for #80379 once I've confirmed. |
|
ofborg only runs aarch64 and x86_64 with the test command, we could do |
Ooh that's pretty cool. |
|
|
The package builds on i686-linux, but the amount of things to build for the nixosTest would take hours 🤣 |
|
backported in 5c4224e |
worldofpeace
added
the
8.has: port to stable
We'll wait for the next evaluation then. |
|
|
it's at least passing locally for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The test
test_cookiejaris failing because a time_t constant can't be represented on 32bit platforms. This is causing failures of all nixos tests on i686-linux.Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)