mint: 0.5.0 -> 0.7.1 #80391
Merged
mint: 0.5.0 -> 0.7.1 #80391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes the build with the latest crystal version
2 tasks
Br1ght0ne
requested changes
Feb 18, 2020
There was a problem hiding this comment.
nixpkgs-review doesn't pass
[0 built (1 failed)]
error: build of '/nix/store/w80af30mcg32a4lrbxykwr3kisb87nyc-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80391
1 package failed to build:
mint
This bug is fixed in #80390
impure path `/homeless-shelter/.cache/crystal/build-source-lib-baked_file_system-src-loader.cr/macro_run' used in link
collect2: error: ld returned 1 exit status
So this should work with Crystal 0.33.0
|
@filalex77 Huh weird, both me and ofborg seem to be able to build it successfully on Linux. Or are you on Darwin perhaps? |
|
@infinisil This ran on Ubuntu 18.04 with single-user Nix installed. I'll try to run it on NixOS. |
jonringer
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This also fixes the build with the latest crystal version
Don't backport this, 20.03 can be fixed without a version update
Things done