crystal_0_32: Fix hydra build on 20.03 #80389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As #80390 is being worked on (by me), and the described failures no longer occur, I propose this PR be closed after 0.33.0 is merged. |
|
@filalex77 20.03 feature freeze has already happened, so even version updates shouldn't go into it anymore. We can have 0.33 on master, but I think this patch here is better for 20.03. I'll change this to target 20.03 only though. |
|
@infinisil Sure, I can get behind this. I'll try to remember not to backport this one to the release branch. |
It seems that there might be hydra machines that run an older version of Nix where NixOS/nix#2878 is not yet included (unconfirmed) In addition crystal 0.32.1 has a bug that only occurs when there is no tty: crystal-lang/crystal#8609 Combining this lead to a crystal build failing: https://hydra.nixos.org/build/113074265 This fixes that probably rather uncommon occurence by applying the upstream fix for the bug: crystal-lang/crystal#8609
infinisil
force-pushed
the
fix/crystal
branch
from
5946015
to
fc1bbc0
Compare
infinisil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It seems that there might be hydra machines that run an older version of Nix
where NixOS/nix#2878 is not yet included
(unconfirmed)
In addition crystal 0.32.1 has a bug that only occurs when there is no
tty: crystal-lang/crystal#8609
Combining this lead to a crystal build failing: https://hydra.nixos.org/build/113074265
This fixes that probably rather uncommon occurence by applying the
upstream fix for the bug: crystal-lang/crystal#8609
Ping @peterhoeg @manveru @david50407
Relevant for ZHF #80379
Things done