mint: Pin to crystal 0.30 to fix build #80392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Br1ght0ne
approved these changes
Feb 18, 2020
worldofpeace
approved these changes
Feb 18, 2020
|
Ah yeah the reason is just that before mint-lang/mint@770e4a7 (in 0.7.1), it only supported crystal versions up to 0.30 |
|
I'll also quickly look into the darwin failure for crystal 0.30 itself |
|
Turns out all (non-binary) crystal versions fail on Darwin, but only if the sandbox is enabled. So I think it's nothing to worry about, since it's disabled by default on Darwin, and I didn't see a quick fix for when it's enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes the mint build on 20.03 that was broken due to newer crystal versions
Relevant for ZHF #80379
Master is fixed by updating mint in #80391
Things done