Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.16.5 -> 1.17.3 (backport) #80441

Merged
merged 1 commit into from Mar 11, 2020
Merged

kubernetes: 1.16.5 -> 1.17.3 (backport) #80441

merged 1 commit into from Mar 11, 2020

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Feb 18, 2020

Motivation for this change

In order to be up-to-date with Kubernetes, we want 1.17.X to be part of 20.03. Preliminary run of NixOS tests looks fine, but we need to test some more. I plan to spin up a GCE cluster soon and do some more testing. @saschagrunert @srhb can you perhaps help making this happen?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@johanot johanot mentioned this pull request Feb 18, 2020
Merged
10 tasks
@johanot johanot changed the title kubernetes: 1.16.5 -> 1.17.3 kubernetes: 1.16.5 -> 1.17.3 (backport) Feb 18, 2020
saschagrunert
saschagrunert approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, I'll give it some local tests 👍

saschagrunert
saschagrunert approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, I'll give it some local tests 👍

@johanot
Copy link
Contributor Author

johanot commented Feb 18, 2020

Just tested on a small 3 node GCE cluster. Looks fine so far.

@srhb
Copy link
Contributor

srhb commented Mar 11, 2020

Please make this a git cherry-pick -xe 66556afb5ab4ff4b30eb9b3f9d7eec2f1e5de32a for good measure

kubernetes: 1.16.5 -> 1.17.3
5ee843e 
(cherry picked from commit 66556af)
@ofborg ofborg bot requested a review from saschagrunert March 11, 2020 09:03
saschagrunert
saschagrunert approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srhb srhb merged commit fede49f into NixOS:release-20.03 Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johanot @srhb @saschagrunert