Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lepton: enable on darwin #80489

Merged
merged 1 commit into from Feb 19, 2020
Merged

lepton: enable on darwin #80489

merged 1 commit into from Feb 19, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Feb 19, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Feb 19, 2020
@ofborg ofborg bot requested a review from artemist February 19, 2020 02:10
@artemist
Copy link
Member

Your edits look good. I was a little concerned since it didn't build on AArch64, but your force push fixed the platform. Unfortuantely I don't have a mac to test.

artemist
artemist approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@artemist artemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good (thanks for updating to use a tag in the commit). I don't have a mac to test, but since you said it works I'll approve it.

@marsam marsam merged commit effebb9 into NixOS:master Feb 19, 2020
@marsam marsam deleted the enable-lepton-darwin branch February 19, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemist artemist artemist approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @artemist