Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes: 1.16.5 -> 1.17.3 #80443

Merged
merged 1 commit into from Mar 11, 2020
Merged

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Feb 18, 2020

Motivation for this change

Doing things in the opposite order here, sorry. I already opened: #80441 against release-20.03.

cc @saschagrunert @srhb

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, I'll give it some local tests 👍

@saschagrunert
Copy link
Member

I think we're good to go from my side. I did some small tests with a local setup (via the e2e conformance tests of kubernetes)

Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also done some smoke testing, and LGTM

@srhb
Copy link
Contributor

srhb commented Mar 3, 2020

Are we good to go on this? 😃

@saschagrunert
Copy link
Member

Yes! 🥳

@srhb srhb merged commit 9979ce4 into NixOS:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants