Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mimalloc: 1.1.0 -> 1.6.1 #80403

Merged
merged 1 commit into from Feb 19, 2020
Merged

mimalloc: 1.1.0 -> 1.6.1 #80403

merged 1 commit into from Feb 19, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Feb 18, 2020

Motivation for this change

upstream release(s)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @thoughtpolice

@ofborg ofborg bot requested a review from thoughtpolice February 18, 2020 03:10
jonringer
jonringer approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80403
1 package built:
mimalloc

outputs look right:

[23:25:02] jon@jon-desktop /home/jon/projects/nixpkgs (master)
$ tree ./result
./result
└── lib
    ├── libmimalloc.a
    ├── libmimalloc.so -> libmimalloc.so.1.0
    ├── libmimalloc.so.1.0
    └── mimalloc.o

1 directory, 4 files

[nix-shell:/home/jon/.cache/nixpkgs-review/pr-80403]$ tree ./results/mimalloc
./results/mimalloc
└── lib
    ├── libmimalloc.a
    ├── libmimalloc.so -> libmimalloc.so.1.6
    ├── libmimalloc.so.1.6
    └── mimalloc.o

1 directory, 4 files

@jonringer
Copy link
Contributor

@GrahamcOfBorg build mimalloc

@jonringer
Copy link
Contributor

darwin failure:

/nix/store/h7i49dl44vcsb0mls05xmwjfyzj42p3z-mimalloc-1.6.1/lib/mimalloc-1.6/libmimalloc.1.6.dylib
/nix/store/h7i49dl44vcsb0mls05xmwjfyzj42p3z-mimalloc-1.6.1/lib/mimalloc-1.6/libmimalloc.a
/nix/store/h7i49dl44vcsb0mls05xmwjfyzj42p3z-mimalloc-1.6.1/lib/mimalloc-1.6/libmimalloc.dylib
/nix/store/h7i49dl44vcsb0mls05xmwjfyzj42p3z-mimalloc-1.6.1/lib/mimalloc-1.6/mimalloc.o
mv: cannot stat '/nix/store/h7i49dl44vcsb0mls05xmwjfyzj42p3z-mimalloc-1.6.1/lib/mimalloc-1.6/libmimalloc.dylib.1.6': No such file or directory

@ajs124
Copy link
Member Author

ajs124 commented Feb 18, 2020

I'm not sure this ever worked. It definitely doesn't work right now.

@jonringer
Copy link
Contributor

mind adding badPlatforms = lib.platforms.darwin; to the meta, so hydra isn't constantly reevaluating it.

@thoughtpolice thoughtpolice merged commit 194f3aa into NixOS:master Feb 19, 2020
@ajs124 ajs124 deleted the upd/mimalloc branch March 11, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @jonringer @thoughtpolice