Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: add rustc.llvm to buildInputs #80401

Merged
merged 1 commit into from Feb 18, 2020
Merged

clippy: add rustc.llvm to buildInputs #80401

merged 1 commit into from Feb 18, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Feb 18, 2020 •
edited

Motivation for this change

The Hydra build [1] failed because it was unable to link to LLVM9; add
llvmShared to passthru in order to stay up to date with required
LLVM versions. Also quote the homepage URLs, since that's preferred.

[1] https://hydra.nixos.org/build/112989779/nixlog/1

ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Should llvm_9 go somewhere else? I'm still not clear on buildInputs vs propagatedBuildInputs. Should it be gated depending on which Rust version is used (since it appears to have built fine in 1.40.0)? How would I do that? Hope I did this right 馃槄

@cole-h cole-h changed the title clippy: add llvm9 to buildInputs clippy: add llvm_9 to buildInputs Feb 18, 2020
@cole-h
clippy: add rustc.llvm to buildInputs
502c0ee 
The Hydra build [1] failed because it was unable to link to `LLVM9`; add
`llvmShared` to `passthru` in order to stay up to date with required
LLVM versions. Also quote the homepage URLs, since that's preferred.

[1] https://hydra.nixos.org/build/112989779/nixlog/1
@cole-h cole-h requested a review from Mic92 February 18, 2020 16:47
@cole-h cole-h changed the title clippy: add llvm_9 to buildInputs clippy: add rustc.llvm to buildInputs Feb 18, 2020
@Mic92 Mic92 merged commit 9fee338 into NixOS:master Feb 18, 2020
@cole-h cole-h deleted the clippy branch February 18, 2020 22:06
This was referenced Feb 18, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@basvandijk basvandijk Awaiting requested review from basvandijk

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cole-h @Mic92