pythonPackages.scan-build: init at 2.0.18 #80374
Conversation
malob
force-pushed
the
add-scan-build
branch
from
8bad015
to
d37c032
Compare
| }; | ||
|
|
||
| checkInputs = [ nose ]; | ||
| checkPhase = "nosetests tests/unit"; |
There was a problem hiding this comment.
not sure what the nose equivalent would be, but I would do this in pytest:
# ignore odd clang tests
checkInputs = [ pytest clang ];
checkPhase = ''
pytest tests/unit -k 'not sip and not get_clang_arguments_fails'
'';
There was a problem hiding this comment.
Alrighty, I've done the equivalent, tests are now passing.
There was a problem hiding this comment.
I disabled two tests, the 'sip' test is still failing:
builder for '/nix/store/5srpjrm27mfscprqxipgf07f64pd1rsy-python3.8-scan-build-2.0.18.drv' failed with exit code 1; last 10 log lines:
self.assertTrue(sut.is_preload_disabled(osx))
AssertionError: False is not true
-------------------- >> begin captured logging << --------------------
root: DEBUG: exec command ['csrutil', 'status'] in /build/source
--------------------- >> end captured logging << ---------------------
----------------------------------------------------------------------
Ran 74 tests in 0.676s
FAILED (SKIP=7, failures=1)
builder for '/nix/store/1lh6pv3c46knrm0pscqzvabd8yc9pkl3-python3.7-scan-build-2.0.18.drv' failed with exit code 1; last 10 log lines:
self.assertTrue(sut.is_preload_disabled(osx))
AssertionError: False is not true
-------------------- >> begin captured logging << --------------------
root: DEBUG: exec command ['csrutil', 'status'] in /build/source
--------------------- >> end captured logging << ---------------------
----------------------------------------------------------------------
Ran 74 tests in 0.696s
FAILED (SKIP=7, failures=1)
cannot build derivation '/nix/store/i2h96aq1cqbhffdm8pwvmrhcc8v1jmz9-env.drv': 2 dependencies couldn't be built
[1 built (2 failed), 6 copied (843.8 MiB), 138.0 MiB DL]
error: build of '/nix/store/i2h96aq1cqbhffdm8pwvmrhcc8v1jmz9-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80374
2 package failed to build:
python37Packages.scan-build python38Packages.scan-build
There was a problem hiding this comment.
Huh, that's not failing for me. I'll look into it.
There was a problem hiding this comment.
not sure where scrutil is coming from
malob
force-pushed
the
add-scan-build
branch
from
d37c032
to
aa826dc
Compare
malob
force-pushed
the
add-scan-build
branch
from
aa826dc
to
af8ed4c
Compare
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
|
looks this accidently got shelved. it no longer builds: not to mention the last official release was 4 years ago, I'm skeptical about how maintained this is. the python ecosystem will move past you if you don't constantly hover over it. |
stale
bot
removed
the
2.status: stale
Motivation for this change
scan-buildis a useful tool for C/C++ development that I use frequently, and it would be nice if it were included innixpkgs.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)