Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack: add Darwin target #80377

Merged
merged 3 commits into from Feb 21, 2020
Merged

slack: add Darwin target #80377

merged 3 commits into from Feb 21, 2020

Conversation

ersinakinci
Copy link
Contributor

@ersinakinci ersinakinci commented Feb 17, 2020 •
edited

Motivation for this change

This PR adds Darwin as a target for slack and bumps the version from 4.2.0 to 4.3.3.

For the Darwin target, we have to use hdiutil to mount the dmg and copy the app bundle from there. Using undmg or xpwn to extract the app from the dmg unfortunately yields corrupted binaries.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 17, 2020
@ofborg ofborg bot requested a review from mmahut February 17, 2020 22:01
@mmahut
Copy link
Member

mmahut commented Feb 19, 2020

Looks like 4.3.3 is not out yet?

curl: (22) The requested URL returned error: 403
error: cannot download slack-desktop-4.3.3-amd64.deb from any mirror

@ersinakinci
slack: 4.3.3 -> 4.2.0
5386408 
4.3.3 not available yet for Linux
@ersinakinci
Copy link
Contributor Author

@mmahut you're correct, it's not available for Linux yet, sorry about that. I've downgraded back to 4.2.0.

On a separate note, is there a policy on having multiple versions for different platforms within the same package? Is it considered good/bad practice?

@Mic92
Copy link
Member

Mic92 commented Feb 21, 2020

Having both in the same file is considered good practice. There is not much code sharing but at least the metadata is the same.

@Mic92 Mic92 merged commit fe6a292 into NixOS:master Feb 21, 2020
@ersinakinci ersinakinci changed the title slack: 4.2.0 -> 4.3.3, add Darwin target slack: add Darwin target Feb 21, 2020
@ersinakinci
Copy link
Contributor Author

@Mic92 but which is better, preferring to keep the same version between two different platforms or offering a more recent version for the other platform when one is available? I'm worried about breaking expressions and tooling that depend on the version field, assuming that the package has a single canonical version (example: package search results).

@Mic92
Copy link
Member

Mic92 commented Feb 21, 2020

@earksiinni if the delay between the two is acceptable we could keep one version. Otherwise they could diverge as well.

@ersinakinci ersinakinci deleted the ersin/slack-macos branch February 24, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc Awaiting requested review from grahamc

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ersinakinci @mmahut @Mic92