Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kepubify: init at 3.0.0 #80412

Merged
merged 1 commit into from Feb 19, 2020
Merged

kepubify: init at 3.0.0 #80412

merged 1 commit into from Feb 19, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Feb 18, 2020

Closes #68871

Supersedes #68871, I've added the author as a co-author to this PR.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
kepubify: init at 3.0.0
472b657 
Co-authored-by: Jacob Dillon <jacob.dillon@uconn.edu>
@ofborg ofborg bot requested a review from kalbasit February 18, 2020 06:46
jonringer
jonringer approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
shows usage

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80412
1 package built:
kepubify

@marsam marsam merged commit 134e5dc into NixOS:master Feb 19, 2020
@zowoq zowoq deleted the kepubify branch February 19, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @jonringer @marsam