Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-storage-azcopy: v10.3.2 -> v10.3.4 #80409

Merged
merged 1 commit into from Mar 5, 2020
Merged

azure-storage-azcopy: v10.3.2 -> v10.3.4 #80409

merged 1 commit into from Mar 5, 2020

Conversation

colemickens
Copy link
Member

Motivation for this change

Just a small package bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

colemickens
colemickens commented Feb 18, 2020
View reviewed changes
pkgs/development/tools/azcopy/default.nix

src = fetchFromGitHub {
owner = "Azure";
repo = "azure-storage-azcopy";
rev = "v${version}";
sha256 = "0n4yns81kwwx725smsgqg8hc693ygqlzrgkqdrhrfszkpm205479";
rev = version;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure/azure-storage-azcopy#868

@ofborg ofborg bot requested a review from kalbasit February 18, 2020 06:02
jonringer
jonringer approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80409
1 package built:
azure-storage-azcopy

@jonringer
Copy link
Contributor

@GrahamcOfBorg build azure-storage-azcopy

@colemickens
Copy link
Member Author

rebased, re-nix-review-ed.

[cole@xeep:~/code/nixpkgs-azcopy]$ nix-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/cole/.cache/nixpkgs-review/rev-272b96ce99c46d29e63086f8452fe67c3de209b3/nixpkgs 7aa084521b34efd71e9b17728f605011a1565a36
Preparing worktree (detached HEAD 7aa084521b3)
Updating files: 100% (21112/21112), done.
HEAD is now at 7aa084521b3 Merge pull request #81694 from r-ryantm/auto-update/liblouis
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-272b96ce99c46d29e63086f8452fe67c3de209b3/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 272b96ce99c46d29e63086f8452fe67c3de209b3
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-272b96ce99c46d29e63086f8452fe67c3de209b3/nixpkgs -qaP --xml --out-path --show-trace --meta
derivation 'gnome-tour-0.0.1' has invalid meta attribute 'override'
derivation 'gnome-tour-0.0.1' has invalid meta attribute 'overrideDerivation'
1 package updated:
azure-storage-azcopy (10.3.2 → 10.3.4)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/cole/.cache/nixpkgs-review/rev-272b96ce99c46d29e63086f8452fe67c3de209b3/build.nix
[4 built, 13 copied (54.9 MiB), 8.4 MiB DL]
1 package built:
azure-storage-azcopy

$ nix-shell /home/cole/.cache/nixpkgs-review/rev-272b96ce99c46d29e63086f8452fe67c3de209b3/shell.nix

[nix-shell:~/.cache/nixpkgs-review/rev-272b96ce99c46d29e63086f8452fe67c3de209b3]$

jonringer
jonringer approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80409
1 package built:
azure-storage-azcopy

@jonringer jonringer merged commit 6c6091a into NixOS:master Mar 5, 2020
@colemickens colemickens deleted the nixpkgs-azcopy branch April 20, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colemickens @jonringer