Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mumble: fix build #80500

Merged
1 commit merged into from Feb 19, 2020
Merged

mumble: fix build #80500

1 commit merged into from Feb 19, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Feb 19, 2020

Motivation for this change

FIxes #80491
cc: @ajs124

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from a user and infinisil February 19, 2020 04:33
@jonringer
Copy link
Contributor

I feel like this should be useful if upstreamed

@marsam
Copy link
Contributor Author

marsam commented Feb 19, 2020

It does not happen in upstream because they bundle rnnoise as git submodule. I'm not sure how to upstream this change, but I could try it this weekend

@ghost ghost merged commit 7b73eef into NixOS:master Feb 19, 2020
@marsam marsam deleted the fix-mumble-build branch February 19, 2020 13:11
@jonringer
Copy link
Contributor

Wow, I don't english good xD

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ dasJ approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mumble build broken
3 participants
@marsam @jonringer @dasJ