Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.signedjson: 1.0.0 -> 1.1.0 #80449

Closed
wants to merge 1 commit into from
Closed

pythonPackages.signedjson: 1.0.0 -> 1.1.0 #80449

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 18, 2020 •
edited

Motivation for this change

noticed it was broken reviewing #80447

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer changed the title pythonPackages.signedjson: add typing to python2 pythonPackages.signedjson: 1.0.0 -> 1.1.0 Feb 18, 2020
@jonringer
Copy link
Contributor Author

since #80447 is on pause, going to merge this as it's still an improvement, other branch and just rebase onto master again.

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.signedjson
@GrahamcOfBorg build python3Packages.signedjson
@GrahamcOfBorg build python38Packages.signedjson

@jonringer
Copy link
Contributor Author

unfortunately this breaks matrix-synapse, which is the only consumer:

error: build of '/nix/store/sh6yaln159has3rk0x90kmkdn2gjip28-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80449
1 package failed to build:
matrix-synapse

3 package built:
python27Packages.signedjson python37Packages.signedjson python38Packages.signedjson

@jonringer jonringer closed this Feb 22, 2020
@jonringer jonringer deleted the fix-py2-signedjson branch February 22, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer