Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.googletrans: init at 2.4.0 #80430

Merged
merged 1 commit into from Feb 22, 2020
Merged

pythonPackages.googletrans: init at 2.4.0 #80430

merged 1 commit into from Feb 22, 2020

Conversation

unode
Copy link
Member

@unode unode commented Feb 18, 2020

Motivation for this change

Needed for mnemosyne - see: #80324

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@unode
Copy link
Member Author

unode commented Feb 18, 2020

@ofborg build python37Packages.googletrans

@unode unode force-pushed the googletrans branch 2 times, most recently from 6753276 to a71e107 Compare February 20, 2020 09:01
@unode
Copy link
Member Author

unode commented Feb 20, 2020

@ofborg build python37Packages.googletrans

@unode
Copy link
Member Author

unode commented Feb 20, 2020 •
edited

Hum... now tests run but I can see these becoming flaky if too many builds are triggered and translate.google.com stops responding or throttles retries.

Also, all green but both builds report failure. I'm a bit confused.

I feel tempted to disable tests and add a comment about this. Advice?

@unode unode requested a review from jonringer February 20, 2020 09:10
@jonringer
Copy link
Contributor

tests occur in a sandbox (they don't have access to network), you don't have to worry about it pinging any service

jonringer
jonringer reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running the tests isn't really meaningful as they try to ping endpoint just apply the following

pkgs/development/python-modules/googletrans/default.nix Show resolved Hide resolved
pkgs/development/python-modules/googletrans/default.nix Show resolved Hide resolved
@unode
Copy link
Member Author

unode commented Feb 21, 2020

Add suggestions included.

jonringer
jonringer approved these changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80430
3 package built:
python27Packages.googletrans python37Packages.googletrans python38Packages.googletrans

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.googletrans python37Packages.googletrans python38Packages.googletrans

@jonringer jonringer merged commit e30abff into NixOS:master Feb 22, 2020
@unode unode deleted the googletrans branch February 23, 2020 19:46
This was referenced Feb 27, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@unode @jonringer