Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron: correct casing of MacOS. Fixes #80361 #80362

Merged
merged 1 commit into from Feb 17, 2020
Merged

electron: correct casing of MacOS. Fixes #80361 #80362

merged 1 commit into from Feb 17, 2020

Conversation

jakobrs
Copy link
Contributor

@jakobrs jakobrs commented Feb 17, 2020

Motivation for this change

Makes Electron work on macOS if /nix is on a case-sensitive filesystem. Fixes #80361.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 17, 2020
@jakobrs jakobrs mentioned this pull request Feb 17, 2020
Closed
@veprbl veprbl merged commit 35bae4f into NixOS:master Feb 17, 2020
@jakobrs jakobrs deleted the electron-casing branch February 17, 2020 15:55
veprbl pushed a commit that referenced this pull request Feb 17, 2020
@jakobrs @veprbl
electron: correct casing of MacOS (#80362)
07244aa 
(cherry picked from commit 35bae4f)
cc #80362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisbhartwell travisbhartwell Awaiting requested review from travisbhartwell

@manveru manveru Awaiting requested review from manveru

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Electron is broken on macOS on case-sensitive filesystems
2 participants
@jakobrs @veprbl