Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pykms to 20190611, adapt pykms service #80363

Closed
wants to merge 2 commits into from
Closed

Update pykms to 20190611, adapt pykms service #80363

wants to merge 2 commits into from

Conversation

pvgoran
Copy link
Contributor

@pvgoran pvgoran commented Feb 17, 2020 •
edited

This updates the currently broken pykms package from 20180208 to 20190611 (with a new upstream), and adapts the pykms module to the changes (different binary names, --logfile option required).

Motivation for this change

Fixes #81355.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pvgoran referenced this pull request Feb 17, 2020
@peterhoeg
pykms: 20180208 -> 20190611
bf9cecf 
New upstream.
@ofborg ofborg bot requested a review from peterhoeg February 17, 2020 15:54
@peterhoeg
Copy link
Member

Couple of things:

  1. You need to do git cherry-pick -x [commit] to get the reference
  2. We also need the nixos changes as the binary name has changed: 08f6831 and 81cd220

@peterhoeg @pvgoran
pykms: 20180208 -> 20190611
8e7d528 
New upstream.

(cherry picked from commit bf9cecf)
@peterhoeg @pvgoran
nixos/pymks: log to journal
a4e1cd3 
(cherry picked from commit 81cd220)
@pvgoran pvgoran changed the title pykms: 20180208 -> 20190611 Update pykms to 20190611, adapt pykms service Feb 29, 2020
@pvgoran
Copy link
Contributor Author

pvgoran commented Feb 29, 2020

Couple of things:
1. You need to do git cherry-pick -x [commit] to get the reference
2. We also need the nixos changes as the binary name has changed: 08f6831 and 81cd220

I added cherry-pick references, and added 81cd220. I don't think 08f6831 is applicable: it's a tree-wide change which is orthogonal to the changes in question.

@pvgoran
Copy link
Contributor Author

pvgoran commented Feb 29, 2020

@peterhoeg While I'm at it, I also created #81366 to address some (perceived) shortcomings in the way logging is done in the package and the service.

@flokli
Copy link
Contributor

flokli commented Apr 12, 2020

We don't usually cherry-pick module system deprecations into already released release branches, so I'm not sure if a4e1cd3 can be cherry-picked.

Also, considering 20.03 being around the corner: Is this an issue in master and release-20.03 as well?

@peterhoeg
Copy link
Member

I don't think 08f6831 is applicable:

It touched the file so you would need to adapt the changes from there in the cherry-pick.

I'm with @flokli on not deprecating something in a release version - that's not going to fly.

Any chance you can wait for 20.03?

@flokli
Copy link
Contributor

flokli commented Apr 21, 2020

With 20.03 released 20.03 containing a later version, this can be closed.

@flokli flokli closed this Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pvgoran @peterhoeg @flokli