Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] Backport clippy: add rustc.llvm to buildInputs #80477

Merged
merged 1 commit into from Feb 19, 2020
Merged

[20.03] Backport clippy: add rustc.llvm to buildInputs #80477

merged 1 commit into from Feb 19, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Feb 18, 2020 •
edited

Motivation for this change

The Hydra build [1] failed because it was unable to link to LLVM9; add
llvmShared to passthru in order to stay up to date with required
LLVM versions. Also quote the homepage URLs, since that's preferred.

[1] https://hydra.nixos.org/build/112989779/nixlog/1

(cherry picked from commit 502c0ee)

Part of ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Original PR: #80401

@cole-h
clippy: add rustc.llvm to buildInputs
028effd 
The Hydra build [1] failed because it was unable to link to `LLVM9`; add
`llvmShared` to `passthru` in order to stay up to date with required
LLVM versions. Also quote the homepage URLs, since that's preferred.

[1] https://hydra.nixos.org/build/112989779/nixlog/1

(cherry picked from commit 502c0ee)
@ofborg ofborg bot added the 6.topic: rust label Feb 18, 2020
@ofborg ofborg bot requested a review from basvandijk February 18, 2020 22:38
@Mic92 Mic92 merged commit 57aa6d4 into NixOS:release-20.03 Feb 19, 2020
@cole-h cole-h deleted the clippy-backport branch February 19, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cole-h @Mic92