... hm, that won't work, not that the original attempt did work either, DocumentationTestCase appears flaky.

Can you format your commit message like pythonPackages.decorator: ...?
The contribution guidelines suggest to always try to use an attribute, and that is what's most common.

Okay, applied a patch from unreleased 4.4.2. I think 4.4.2 is going to be released very soon, so it may make more sense to wait for its release instead of updating the package twice.

I made a PR for the fix in micheles/decorator#79, where I also asked for a new release. I think we should wait a bit for that

See also #75554

wait a second, this is targeting staging.

Also, the builds are passing on 20.03

Finished executing setuptoolsCheckPhase
/nix/store/4d2bxibs9bl4609a298mvbp376hhs6dc-python2.7-decorator-4.4.1
[09:22:09] jon@jon-desktop /home/jon/projects/nixpkgs (release-20.03)
$ nix-build -A python3Packages.decorator
/nix/store/nbsca0r5y0qnpjhh74hfl96mp8a6mbvz-python3.7-decorator-4.4.1
[09:22:19] jon@jon-desktop /home/jon/projects/nixpkgs (release-20.03)
$ nix-build -A python38Packages.decorator
/nix/store/9bw8xf24v0625ppjxcx1fpfq0ly7lax9-python3.8-decorator-4.4.1
[09:22:23] jon@jon-desktop /home/jon/projects/nixpkgs (release-20.03)

The build was flaky, sometimes it passed, sometimes it didn't.

that's fair, I didn't get a cache hit on the python2 version

I also think we should go the way as @infinisil suggested #80435 (comment).

I'm also okay with waiting for a new patch version

I don't think the error is python 2 specific, it's just that it just happened to occur for the python 2 build this time

Also we thought this might not need to go to staging, as it's only 500 rebuilds, and python ones at that, which are pretty cheap

Changed the base branch to master. This is a big rebuild, but if you are fine with master, then why not :).

@GrahamcOfBorg build python2Packages.decorator python3Packages.decorator python38Packages.decorator

python2 build is fixed, diff LGTM