Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.django_extensions: 2.2.5 -> 2.2.8 #80396

Merged
merged 1 commit into from Feb 18, 2020
Merged

python3Packages.django_extensions: 2.2.5 -> 2.2.8 #80396

merged 1 commit into from Feb 18, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 18, 2020 •
edited

Motivation for this change

noticed it was broken reviewing another package

cleaned up the expression while bumping/fixing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[10 built, 22 copied (38.4 MiB), 7.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80396
5 package built:
mailman-web paperless python37Packages.django_extensions python37Packages.hyperkitty python38Packages.django_extensions

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 18, 2020
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.bayesian-optimization python37Packages.bayesian-optimization python38Packages.bayesian-optimization

@jonringer
Copy link
Contributor Author

oops, copied from wrong review

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build mailman-web paperless python37Packages.django_extensions python37Packages.hyperkitty python38Packages.django_extensions

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.django_extensions

@jonringer jonringer merged commit fdcb86d into NixOS:master Feb 18, 2020
@jonringer jonringer deleted the bump-django-extensions branch February 18, 2020 03:56
@jonringer jonringer removed the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 18, 2020
@jonringer
Copy link
Contributor Author

this builds fine on the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer