ruamel: moved from bitbucket to sourceforge #80400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
labels
bhipple
requested changes
Feb 18, 2020
There was a problem hiding this comment.
This probably should go to the staging branch given the number of unfortunate rebuilds, but otherwise LGTM. Thanks for the fix!
(Well, maybe not, since most of the rebuilds are probably cheap-to-rebuild python packages, and there's literally no diff here in the src input hash. I'll let a maintainer make the call.)
| owner = "ruamel"; | ||
| repo = "yaml.clib"; | ||
| src = fetchhg { | ||
| url = "http://hg.code.sf.net/p/ruamel-yaml-clib/code"; | ||
| rev = version; | ||
| sha256 = "0kq6zi96qlm72lzj90fc2rfk6nm5kqhk6qxdl8wl9s3a42b0v6wl"; | ||
| }; |
There was a problem hiding this comment.
nix-build -A python3Packages.ruamel_yaml_clib.src --check
LGTM, at least on this front. I'm surprised the hash didn't change between moving fetchers ...
BTW, even though the src input has the same directory hash, the reason this PR is a rebuild-the-world is that we have a dependency on the name of the directory for recursive hashes .... e.g., on master:
# On master
$ nix-build -A python3Packages.ruamel_yaml_clib.src
/nix/store/billhyciaqc7x2x3zhp0xyxld45pbpd8-source
$ nix-hash --type sha256 --base32 /nix/store/billhyciaqc7x2x3zhp0xyxld45pbpd8-source
0kq6zi96qlm72lzj90fc2rfk6nm5kqhk6qxdl8wl9s3a42b0v6wl
# On this PR:
$ nix-build -A python3Packages.ruamel_yaml_clib.src
/nix/store/h9k227wsfwd22bl7qwc8j724ajmxfnfs-hg-archive
$ nix-hash --type sha256 --base32 /nix/store/h9k227wsfwd22bl7qwc8j724ajmxfnfs-hg-archive
0kq6zi96qlm72lzj90fc2rfk6nm5kqhk6qxdl8wl9s3a42b0v6wl
Same hash . . . but the unpacked directory is named hg-archive instead of source, which gets exposed to the buidler via an env var, which causes the rebuild :(
jonringer
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
diff LGTM
commits LGTM
failures are broken on master
[108 built (7 failed), 119 copied (487.2 MiB), 79.0 MiB DL]
error: build of '/nix/store/f6xl6x97h8k48ly5zsca4l519jzrpkbl-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80400
3 package marked as broken and skipped:
bonfire invoice2data python37Packages.mailman-web
7 package failed to build:
ape ntfy python27Packages.ansible-lint python27Packages.secure python37Packages.intake python38Packages.intake topydo
99 package built:
ansible-lint aws-sam-cli azure-cli backblaze-b2 buku cookiecutter csvs-to-sqlite deja-dup devpi-client devpi-server duplicity duply fdroidserver home-assistant home-assistant-cli http-prompt httpie khard lexicon mailman-web mautrix-telegram mitmproxy paperless papis python27Packages.arrow python27Packages.conda python27Packages.cookiecutter python27Packages.dateparser python27Packages.jinja2_time python27Packages.maya python27Packages.python-binance rainbowstream python27Packages.ruamel_yaml python27Packages.ruamel_yaml_clib python27Packages.stravalib python27Packages.strictyaml python37Packages.Nikola python37Packages.arrow python37Packages.conda python37Packages.dateparser python37Packages.dftfit python37Packages.django-q python37Packages.drf-yasg python37Packages.flask-common python37Packages.habanero python37Packages.httpbin python37Packages.hyperkitty python37Packages.ics python37Packages.jinja2_time python37Packages.jupyter-repo2docker python37Packages.knack python37Packages.lammps-cython python37Packages.mautrix python37Packages.maya python37Packages.mesa python37Packages.monty python37Packages.nvchecker python37Packages.pymatgen python37Packages.pymatgen-lammps python37Packages.pytest-httpbin python37Packages.python-binance python37Packages.rainbowstream python37Packages.ruamel_yaml python37Packages.ruamel_yaml_clib python37Packages.secure python37Packages.stravalib python37Packages.strictyaml python37Packages.sumo python37Packages.vcrpy python38Packages.ansible-lint python38Packages.conda python38Packages.csvs-to-sqlite python38Packages.dateparser python38Packages.dftfit python38Packages.drf-yasg python38Packages.flask-common python38Packages.habanero python38Packages.httpbin python38Packages.jupyter-repo2docker python38Packages.knack python38Packages.lammps-cython python38Packages.maya python38Packages.monty python38Packages.nvchecker python38Packages.papis python38Packages.pymatgen python38Packages.pymatgen-lammps python38Packages.pytest-httpbin python38Packages.python-binance python38Packages.ruamel_yaml python38Packages.ruamel_yaml_clib python38Packages.secure python38Packages.strictyaml python38Packages.sumo python38Packages.vcrpy rapid-photo-downloader watson webmacs whipper
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It looks like the ruamel python packages have moved from bitbucket to sourceforge. See for example https://bitbucket.org/ruamel/yaml.clib
This mainly affects ruamel.yaml.clib which was getting source from bitbucket, which now 404s.
Things done
This switches the source to hg sf.net (not sure if this is the right way to do it -- I couldn't find a better fetch for it). It doesn't look like the hashes have changed. I also updated the urls for all three packages.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)