Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatpak: use correct p11-kit output #80453

Merged
merged 1 commit into from Feb 18, 2020
Merged

flatpak: use correct p11-kit output #80453

merged 1 commit into from Feb 18, 2020

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Feb 18, 2020 •
edited

Fixes #80452

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 18, 2020
@ofborg ofborg bot requested a review from jtojnar February 18, 2020 17:41
@ofborg ofborg bot requested a review from jtojnar February 18, 2020 18:16
@worldofpeace worldofpeace merged commit a3eef89 into NixOS:master Feb 18, 2020
@worldofpeace worldofpeace deleted the p11-kit-flatpak branch February 18, 2020 23:14
@worldofpeace
Copy link
Contributor Author

backported to 20.03 in ebf4836

@worldofpeace worldofpeace added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 18, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/flatpak-error-the-name-org-freedesktop-accounts-was-not-provided-by-any-service-file/6000/12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flatpak: p11-kit path patchery should use dev output, that's where /bin/p11-kit is
3 participants
@worldofpeace @nixos-discourse @jtojnar