it's build failed.

@GTrunSec Could you please post the logs here/somewhere? Otherwise, I can't do anything more to try and fix this.

EDIT: The fact that it succeeded for @terlar makes me think either 1) you were just agreeing that this is a problem or 2) you didn't apply this properly (I don't know what the proper way is either, though, which is why I was unable to test it myself).

Weird, for me it worked.

Weird, for me it worked.

yeh, it' worked.

DIT: The fact that it succeeded for @terlar makes me think either 1) you were just agreeing that this is a problem or 2) you didn't apply this properly (I don't know what the proper way is either, though, which is why I was unable to test it myself).

sorry, when I deleted the building garbage, it worked for me.

No worries, glad it worked! Thanks for trying it out and reporting back :)

Who is the owner for this module? Or someone that could make a decision to merge this, feels safe, and won't break stuff more than they currently are on master : )

Repro:

echo '{ ... }: { programs.fish.enable = true; }' > fish-fail.nix
nixos-rebuild build-vm -I nixpkgs=$HOME/Projects/nixpkgs -I nixos-config=fish-fail.nix

If you cannot wait for the nixos-rebuild to finish, just look for something like

these derivations will be built:
  /nix/store/zj2n12p41jrmifr8rrz2af0rzdw5kcvh-fish_patched-completion-generator.drv

in the output and run nix-build /nix/store/zj2n12p41jrmifr8rrz2af0rzdw5kcvh-fish_patched-completion-generator.drv.

I am not sure, but it seems fish installing does not work more.

unpacking sources
unpacking source archive /nix/store/z08mbgrf14gvv13i1hcw8wwjicdgn3k2-fish-3.1.0/share/fish/tools/create_manpage_completions.py
unpacking source archive /nix/store/z08mbgrf14gvv13i1hcw8wwjicdgn3k2-fish-3.1.0/share/fish/tools/deroff.py
source root is .
patching sources
applying patch /nix/store/r2bsz0sgmxjsm7jvcpmc0z113wfvfnkj-fish_completion-generator.patch
patching file create_manpage_completions.py
Hunk #1 FAILED at 776.
1 out of 1 hunk FAILED -- saving rejects to file create_manpage_completions.py.rej

That's the same edited file in this PR 🤔

You'll have to update your nixpkgs channel in order to get the fix. It was just merged yesterday, so you're probably still on an older revision. The most telltale sign of that is the patch fails at line 776 -- the updated patch is starts much later, at line 844.

I'm using the latest unstable (commit e2b4abe) and I'm getting the same error.

If you view the tree at that commit, you can see that this PR has not yet been incorporated: https://github.com/NixOS/nixpkgs/blob/e2b4abe3c8f2e09adfc6a52007841d1b96c89371/nixos/modules/programs/fish_completion-generator.patch.

This means that the commit fixing this is only present on the master branch, and is not on any channels yet. I don't use NixOS, so I cannot give you any other solution than to switch to master until this PR has found its way into nixos-unstable.

@cole-h Alright, thanks for clarifying. I was a little confused by your hint to "update the channel", since it was already updated. But it's fine, I'll simply wait a bit. :)

I could have been a little clearer, sorry ;) It made sense to me because my nixpkgs channel is tracking master. Hopefully nixos-unstable gets bumped sooner rather than later, so you no longer have to deal with this issue!

Just a little update: according to https://howoldis.herokuapp.com/, nixos-unstable has advanced to ea79a830dcf, whose tree includes this patch 🎉