Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] nixos/release-combined; migrate constituents list to strings #80454

Merged
merged 2 commits into from Feb 20, 2020

Conversation

andir
Copy link
Member

@andir andir commented Feb 18, 2020

Motivation for this change

As of a few days ago hydra has a different GC configuration that leads
to eval failures when the tested job has a direct dependency on all
the tests. This is an attempt at migrating the old list of jobs to the
new format while keeping the logic and the tests the same.

Currently channel bumps of nixos-19.09 are being blocked. This should unblock it.

Things done

Testing eval for the new format doesn't seem to be straight forward from my point of view and my laptop lacks enough memory to do it..

Hopefully someone with the right flavor and version of nix installed can use the new nix hydra-eval-jobs command to test this.


cc @edolstra

@edolstra
Copy link
Member

We also need 8950429, since the tested job of the small channel also takes 20 GiB to evaluate.

@edolstra
Copy link
Member

I also noticed tested in release-combined is returning some nested lists, which nix eval-hydra-jobs doesn't support:

$ nix eval --json --file nixos/release-combined.nix tested.constituents | jq .
[
  "nixos.channel",
  [
    "nixos.dummy.x86_64-linux"
  ],
  [
    "nixos.manual.x86_64-linux"
  ],
...

Could you flatten the list?

@vcunat
Copy link
Member

vcunat commented Feb 18, 2020

Wait with this, please. On master and 20.03 the lists seem flat but Hydra aborts them anyway and thus channels are blocked (even -small ones).

As of a few days ago hydra has a different GC configuration that leads
to eval failures when the tested job has a direct dependency on all the
tests. This is an attempt at migrating the old list of jobs to the new
format while keeping the logic and the tests the same.
As of a few days ago hydra has a different GC configuration that leads
to eval failures when the tested job has a direct dependency on all the
tests. This is an attempt at migrating the old list of jobs to the new
format while keeping the logic and the tests the same.
@andir
Copy link
Member Author

andir commented Feb 19, 2020

@edolstra list has been flattend and the small set has been added as well.

We should probably address the point that @vcunat raised.

@vcunat
Copy link
Member

vcunat commented Feb 19, 2020

That one's probably solved. -small tested jobs succeeded already, so I expect the big ones will do the same once their dependencies have finished.

@andir
Copy link
Member Author

andir commented Feb 20, 2020

Any objections to merging this in? Anything else to be done?

@vcunat
Copy link
Member

vcunat commented Feb 20, 2020

I see no objections.

The 19.09 jobset has been unable to evaluate for almost a week; I'm not sure why, perhaps this is "the error"?

error: unexpected EOF reading a line

Perhaps it is some kind of resource exhaustion and merging this will fix that 🤷‍♀️

@andir
Copy link
Member Author

andir commented Feb 20, 2020 via email

@edolstra edolstra merged commit 7d5d07f into NixOS:release-19.09 Feb 20, 2020
@edolstra
Copy link
Member

Thanks!

error: unexpected EOF reading a line probably means one of the evaluator worker processes died with an OOM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants