Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metasploit: 5.0.45 -> 5.0.74 #80404

Merged
merged 1 commit into from Feb 18, 2020
Merged

metasploit: 5.0.45 -> 5.0.74 #80404

merged 1 commit into from Feb 18, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Feb 18, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

find it semi-ironic that the PR has a 404 suffix

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
executables appear to work

[101 built, 93 copied (74.8 MiB), 14.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80404
1 package built:
metasploit

still get some noise though, but this is probably a ruby/metasploit behavoir:

[nix-shell:/home/jon/.cache/nixpkgs-review/pr-80404]$ ./results/metasploit/bin/msfconsole --help
Following files may not be writable, so sudo is needed:
  /nix/store/c6ak37kddbivr8y3d321c5jmmcvayl8s-metasploit-bundler-env/lib/ruby/gems/2.6.0
  /nix/store/c6ak37kddbivr8y3d321c5jmmcvayl8s-metasploit-bundler-env/lib/ruby/gems/2.6.0/bin
  /nix/store/c6ak37kddbivr8y3d321c5jmmcvayl8s-metasploit-bundler-env/lib/ruby/gems/2.6.0/bin
  /nix/store/c6ak37kddbivr8y3d321c5jmmcvayl8s-metasploit-bundler-env/lib/ruby/gems/2.6.0/build_info
  /nix/store/c6ak37kddbivr8y3d321c5jmmcvayl8s-metasploit-bundler-env/lib/ruby/gems/2.6.0/build_info/nokogiri-1.10.8.info
  /nix/store/c6ak37kddbivr8y3d321c5jmmcvayl8s-metasploit-bundler-env/lib/ruby/gems/2.6.0/build_info/pg-0.21.0.info
  /nix/store/c6ak37kddbivr8y3d321c5jmmcvayl8s-metasploit-bundler-env/lib/ruby/gems/2.6.0/build_info/sqlite3-1.4.2.info
  /nix/store/c6ak37kddbivr8y3d321c5jmmcvayl8s-metasploit-bundler-env/lib/ruby/gems/2.6.0/bundler
  /nix/store/c6ak37kddbivr8y3d321c5jmmcvayl8s-metasploit-bundler-env/lib/ruby/gems/2.6.0/cache
  /nix/store/c6ak37kddbivr8y3d321c5jmmcvayl8s-metasploit-bundler-env/lib/ruby/gems/2.6.0/doc
  /nix/store/c6ak37kddbivr8y3d321c5jmmcvayl8s-metasploit-bundler-env/lib/ruby/gems/2.6.0/extensions
  /nix/store/c6ak37kddbivr8y3d321c5jmmcvayl8s-metasploit-bundler-env/lib/ruby/gems/2.6.0/gems
  /nix/store/c6ak37kddbivr8y3d321c5jmmcvayl8s-metasploit-bundler-env/lib/ruby/gems/2.6.0/specifications
Usage: msfconsole [options]
...

Copy link
Contributor

@makefu makefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested msfconsole with nmap and msfvenom. checks out

@jonringer jonringer merged commit 72c1451 into NixOS:master Feb 18, 2020
@zowoq zowoq deleted the metasploit branch February 18, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants