Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 07244aa21bf1
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 47dfd37e5a94
Choose a head ref
  • 4 commits
  • 4 files changed
  • 2 contributors

Commits on Feb 15, 2020

  1. knot: put runtime paths outside the nix store 

    Otherwise knot tries to write to non-writable directories.
This for example breaks dnssec signing.
While it's possible to overwrite these path in the configuration,
having a sane defaults is nicer.

(cherry picked from commit 6adc09e)
    @Mic92
    Mic92 committed Feb 15, 2020
    Copy the full SHA
    e989a19 View commit details
    Browse the repository at this point in the history

  2. knot: drop dynamic user 

    This makes it hard to include secret files.
Also using tools like keymgr becomes harder.

(cherry picked from commit 88029bc)
    @Mic92
    Mic92 committed Feb 15, 2020
    Copy the full SHA
    0af3b75 View commit details
    Browse the repository at this point in the history

  3. knot: add keyFiles option 

    This useful to include tsig keys using nixops without adding those
world-readable to the nix store.

(cherry picked from commit e2ef8b4)
    @Mic92
    Mic92 committed Feb 15, 2020
    Copy the full SHA
    8325e2b View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2020

  1. Merge pull request #80172 from Mic92/knot-backport 

    [20.03-backport] knot: keyFiles, no dynamicUser
    @Mic92
    Mic92 committed Feb 17, 2020
    Copy the full SHA
    47dfd37 View commit details
    Browse the repository at this point in the history