Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.qiskit-terra: init at 0.12.0 #80464

Merged
merged 1 commit into from Feb 25, 2020
Merged

pythonPackages.qiskit-terra: init at 0.12.0 #80464

merged 1 commit into from Feb 25, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Update qiskit according to new upstream package structure (collection of subpackages). This is broken out of #78772. Would like to get it into 20.03 if at all possible. Has one out-of-tree dependency: pythonPackages.pylatexenc (#78878). Will rebase & remove that commit when #78878 is approved.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger drewrisinger mentioned this pull request Feb 18, 2020
Merged
10 tasks
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.qiskit-terra python38Packages.qiskit-terra

jonringer
jonringer reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/development/python-modules/qiskit-terra/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/qiskit-terra/default.nix Outdated Show resolved Hide resolved
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.qiskit-terra python38Packages.qiskit-terra

@drewrisinger drewrisinger mentioned this pull request Feb 20, 2020
Merged
10 tasks
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.qiskit-terra python38Packages.qiskit-terra
(fixed commit naming outdated qiskit version)

jonringer
jonringer approved these changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the tests aren't too damaging to the huge size of the closure already:

[nix-shell:/home/jon/.cache/nixpkgs-review/pr-80464-1]$ nix path-info -Sh ./results/python37Packages.qiskit-terra
/nix/store/rrwx7l0gq49cc9zb3y49zkx8vy7j4y5m-python3.7-qiskit-terra-0.12.0	 388.2M
[nix-shell:/home/jon/.cache/nixpkgs-review/pr-80464-1]$ du -hd0 ./results/python37Packages.qiskit-terra/lib/python3.7/site-packages/test/
4.5M	./results/python37Packages.qiskit-terra/lib/python3.7/site-packages/test/
[nix-shell:/home/jon/.cache/nixpkgs-review/pr-80464-1]$ du -hd0 ./results/python37Packages.qiskit-terra/lib/python3.7/site-packages/examples/
96K	./results/python37Packages.qiskit-terra/lib/python3.7/site-packages/examples/

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.qiskit-terra python38Packages.qiskit-terra

@drewrisinger
pythonPackages.qiskit-terra: init at 0.12.0
d3cdcb6 
Qiskit is a quantum information toolkit from IBM. This commit
follows the new Qiskit scheme of breaking from one large package into
smaller packages (terra, aer, etc), and then having a single
meta-package "qiskit" that comprises them.
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.qiskit-terra python38Packages.qiskit-terra
Removed test & example dirs in postCheck. Clarified a few comments. Should be good now.

jonringer
jonringer approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80464
2 package built:
python37Packages.qiskit-terra python38Packages.qiskit-terra

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.qiskit-terra python38Packages.qiskit-terra

@jonringer jonringer merged commit 49ad19b into NixOS:master Feb 25, 2020
@drewrisinger drewrisinger deleted the dr-pr-python-qiskit-terra branch February 25, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @jonringer