Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "hdf5-fortran: Mark broken on Darwin" #80419

Merged
merged 1 commit into from Feb 18, 2020
Merged

Revert "hdf5-fortran: Mark broken on Darwin" #80419

merged 1 commit into from Feb 18, 2020

Conversation

tviti
Copy link
Contributor

@tviti tviti commented Feb 18, 2020

This reverts commit 8836c4d.

Closes #79952

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Feb 18, 2020
@veprbl
Copy link
Member

veprbl commented Feb 18, 2020

@GrahamcOfBorg build hdf5-fortran

@veprbl veprbl merged commit 2cfad8f into NixOS:master Feb 18, 2020
@veprbl
Copy link
Member

veprbl commented Feb 18, 2020

@tviti Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should HDF5 be unmarked as broken on Darwin?
2 participants
@tviti @veprbl