Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

godot: 3.1.2 -> 3.2 #80380

Closed
wants to merge 1 commit into from
Closed

godot: 3.1.2 -> 3.2 #80380

wants to merge 1 commit into from

Conversation

invpt
Copy link

@invpt invpt commented Feb 17, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@invpt invpt changed the title Godot 3.1.2 -> 3.2 godot: 3.1.2 -> 3.2 Feb 17, 2020
@marsam
Copy link
Contributor

marsam commented Feb 18, 2020

@GrahamcOfBorg build godot

@juliendehos
Copy link
Contributor

maybe related to #79957

@invpt
Copy link
Author

invpt commented Feb 18, 2020

oops, I didn't see that, my bad.

@invpt invpt closed this Feb 18, 2020
@juliendehos
Copy link
Contributor

However, I don't know if the PRs are identical so please feel free to test & comment the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@invpt @marsam @juliendehos @Janik-Haag