Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_5.compiler-rt: Backport llvm 6.x's ustat fix after glibc… #80381

Closed
wants to merge 1 commit into from
Closed

llvmPackages_5.compiler-rt: Backport llvm 6.x's ustat fix after glibc… #80381

wants to merge 1 commit into from

Conversation

chkno
Copy link
Member

@chkno chkno commented Feb 17, 2020

Motivation for this change

ZHF: #80379 Fixes https://hydra.nixos.org/build/113047930/nixlog/1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
Copy link
Contributor

Either this or https://github.com/NixOS/nixpkgs/pull/80124/files should be closed.

@doronbehar doronbehar mentioned this pull request Feb 23, 2020
Merged
10 tasks
@vcunat vcunat closed this Mar 2, 2020
@vcunat
Copy link
Member

vcunat commented Mar 2, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblasc lblasc lblasc approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chkno @doronbehar @vcunat @lblasc