New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.pytorch-metric-learning: init at 0.9.81 #80458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style looks pretty good, haven't tested build.
pkgs/development/python-modules/pytorch-metric-learning/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/pytorch-metric-learning/default.nix
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (after other suggestions)
error: build of '/nix/store/nwdjlgsrncxl37k122w9qx3i14pn0rn9-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80458
1 package failed to build:
python38Packages.pytorch-metric-learning
1 package built:
python37Packages.pytorch-metric-learning
451bb66
to
29fc1da
Compare
Everything resolved, package updated, now has tests. python38Packages.pytorch is currently failing to build though. |
Due to what? test failure? upstream dependency? |
@GrahamcOfBorg build python37Packages.pytorch-metric-learning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, otherwise LGTM.
29fc1da
to
b20f22d
Compare
@GrahamcOfBorg build python2Packages.pytorch-metric-learning python37Packages.pytorch-metric-learning python38Packages.pytorch-metric-learning |
Result of 20 packages marked as broken and skipped:- digitalbitbox - linuxPackages_4_4.evdi - linuxPackages_hardkernel_4_14.bcc - linuxPackages_hardkernel_4_14.bpftrace - linuxPackages_hardkernel_4_14.can-isotp - linuxPackages_hardkernel_4_14.chipsec - linuxPackages_hardkernel_4_14.digimend - linuxPackages_hardkernel_4_14.evdi - linuxPackages_hardkernel_4_14.mba6x_bl - linuxPackages_hardkernel_4_14.nvidia_x11 - linuxPackages_hardkernel_4_14.nvidia_x11_legacy390 - linuxPackages_hardkernel_4_14.nvidiabl - php73Extensions.zmq - php74Extensions.pcs - php74Extensions.pthreads - python27Packages.caffe - python27Packages.libmodulemd - python37Packages.pyblock - python38Packages.libselinux - python38Packages.pyblock 2 packages built:- python37Packages.pytorch-metric-learning - python38Packages.pytorch-metric-learning |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)