Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pytorch-metric-learning: init at 0.9.81 #80458

Merged
merged 1 commit into from May 26, 2020

Conversation

bcdarwin
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style looks pretty good, haven't tested build.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (after other suggestions)

error: build of '/nix/store/nwdjlgsrncxl37k122w9qx3i14pn0rn9-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80458
1 package failed to build:
python38Packages.pytorch-metric-learning

1 package built:
python37Packages.pytorch-metric-learning

@bcdarwin bcdarwin force-pushed the pytorch-metric-learning branch 2 times, most recently from 451bb66 to 29fc1da Compare March 31, 2020 04:12
@bcdarwin bcdarwin changed the title python3Packages.pytorch-metric-learning: init at 0.9.73 python3Packages.pytorch-metric-learning: init at 0.9.81 Mar 31, 2020
@bcdarwin
Copy link
Member Author

bcdarwin commented Mar 31, 2020

Everything resolved, package updated, now has tests. python38Packages.pytorch is currently failing to build though.

@drewrisinger
Copy link
Contributor

Everything resolved, package updated, now has tests. python38Packages.pytorch is currently failing to build though.

Due to what? test failure? upstream dependency?

@drewrisinger
Copy link
Contributor

@GrahamcOfBorg build python37Packages.pytorch-metric-learning
@GrahamcOfBorg build python38Packages.pytorch-metric-learning

Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, otherwise LGTM.

@bcdarwin
Copy link
Member Author

@GrahamcOfBorg build python2Packages.pytorch-metric-learning python37Packages.pytorch-metric-learning python38Packages.pytorch-metric-learning

@bcdarwin bcdarwin requested a review from bhipple May 26, 2020 00:57
@bhipple
Copy link
Contributor

bhipple commented May 26, 2020

Result of nixpkgs-review pr 80458 1

20 packages marked as broken and skipped:
- digitalbitbox
- linuxPackages_4_4.evdi
- linuxPackages_hardkernel_4_14.bcc
- linuxPackages_hardkernel_4_14.bpftrace
- linuxPackages_hardkernel_4_14.can-isotp
- linuxPackages_hardkernel_4_14.chipsec
- linuxPackages_hardkernel_4_14.digimend
- linuxPackages_hardkernel_4_14.evdi
- linuxPackages_hardkernel_4_14.mba6x_bl
- linuxPackages_hardkernel_4_14.nvidia_x11
- linuxPackages_hardkernel_4_14.nvidia_x11_legacy390
- linuxPackages_hardkernel_4_14.nvidiabl
- php73Extensions.zmq
- php74Extensions.pcs
- php74Extensions.pthreads
- python27Packages.caffe
- python27Packages.libmodulemd
- python37Packages.pyblock
- python38Packages.libselinux
- python38Packages.pyblock
2 packages built:
- python37Packages.pytorch-metric-learning
- python38Packages.pytorch-metric-learning

@bhipple bhipple merged commit 82fbcf6 into NixOS:master May 26, 2020
@bcdarwin bcdarwin deleted the pytorch-metric-learning branch May 26, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants