Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdbook: upgrade cargo fetcher and cargoSha256 #80395

Merged
merged 1 commit into from Feb 18, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Feb 18, 2020

Infra upgrade as part of #79975; ran nixpkgs-review wip successfully.

Infra upgrade as part of NixOS#79975; ran `nixpkgs-review wip` successfully.
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build mdbook

@bhipple
Copy link
Contributor Author

bhipple commented Feb 18, 2020

@worldofpeace I actually did have this script posting that comment automatically in the previous iteration, but per comment from @grahamc himself it's not necessary!

I think posting it kicks the builder to start building instantly, while otherwise it should eventually come through and do it on its own. Let's wait and see on #80399, which has currently been open for 10 minutes with no OfBorg signs of life . . .

EDIT: It did eventually wake up! It took about 25 minutes; I'm guessing the comment is the difference between push-based triggering and poll-based triggering, with the latter only happening when OfBorg is actually ready to start processing.

@grahamc
Copy link
Member

grahamc commented Feb 18, 2020

image

@grahamc
Copy link
Member

grahamc commented Feb 18, 2020

ofborg's builds aren't poll-based, the builds are triggered once the evaluations complete.

@grahamc
Copy link
Member

grahamc commented Feb 18, 2020

Side note: it used to be required to trigger the builds for any PR where the person opening the PR wasn't pre-approved. ofborg now automatically builds all PRs, no matter who opens them. The only remaining difference is whether or not they are triggered on darwin.

@bhipple
Copy link
Contributor Author

bhipple commented Feb 18, 2020

Right, but the "Some checks haven't completed yet" (or any status/signs of life at all) didn't pop up for ~25 minutes. It'd be nice if ofborg immediately set the status as pending on PR opens, so those impatient humans don't try to poke it unnecessarily!

(If you post the comment, it instantly sets the status to pending, at which point you know to just sit tight.)

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/80395
1 package built:
mdbook

@jonringer jonringer merged commit 4b212b9 into NixOS:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants