Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] Backport riot updates #80394

Merged
merged 3 commits into from Feb 20, 2020
Merged

[20.03] Backport riot updates #80394

merged 3 commits into from Feb 20, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien @worldofpeace
riot-web: 1.5.8 -> 1.5.9
70e97c8 
(cherry picked from commit 85e09da)
@pacien @worldofpeace
riot-desktop: 1.5.6 -> 1.5.9
72fcbcf 
(cherry picked from commit 5bd9230)
@pacien @worldofpeace
riot-web: add config overrides for privacy
9793597 
Preventing the app from phoning home by default.

GitHub: closes NixOS#80358
(cherry picked from commit c9e5cca)
@ofborg ofborg bot requested a review from pacien February 18, 2020 01:24
@worldofpeace
Copy link
Contributor Author

Got a segfault trying to open links

/run/current-system/sw/bin/xdg-open: line 650: 32519 Segmentation fault      (core dumped) gio open "$1"

@pacien
Copy link
Contributor

pacien commented Feb 18, 2020 •
edited

@worldofpeace wrote:

Got a segfault trying to open links

/run/current-system/sw/bin/xdg-open: line 650: 32519 Segmentation fault      (core dumped) gio open "$1"

I couldn't reproduce the segfault. Links are opening normally for me.

You might still want to try with newer versions of Electron though.

@fpletz fpletz merged commit 2b58a9f into NixOS:release-20.03 Feb 20, 2020
@worldofpeace worldofpeace deleted the backport-riot-updates branch February 20, 2020 02:31
@expipiplus1
Copy link
Contributor

@worldofpeace did you find a solution to these segfaults? I'm getting the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacien pacien Awaiting requested review from pacien

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @pacien @expipiplus1 @fpletz