[do not merge] tarball: Workaround bad branch names #3364
Conversation
Currently, from a git checkout, using `nix-build` fails like this for me: ``` [...] GEN nix-2.4pre0_dirty.tar.bz2 tar: .git/logs/refs/remotes/origin/mojave-/homeless-shelter: Cannot stat: No such file or directory tar: .git/refs/remotes/origin/mojave-/homeless-shelter: Cannot stat: No such file or directory tar: Exiting with failure status due to previous errors make: *** [mk/dist.mk:8: nix-2.4pre0_dirty.tar.bz2] Error 2 ``` As can be deduced from the two `No such file or directory`, the files listing in `.dist-files` gets expanded once used by `tar`. The branch name is `mojave-$HOME`. This is a *dumb workaround* rather than a proper fix. Fixing this by escaping using `sed` to double-up the `$` fails like this: ``` make: *** No rule to make target '.git/logs/refs/remotes/origin/mojave-$$HOME', needed by 'nix-2.4pre0_dirty.tar.bz2'. Stop. ``` And trying to escape it as `\$` fails like this: ``` make: *** No rule to make target '.git/logs/refs/remotes/origin/mojave-\$HOME', needed by 'nix-2.4pre0_dirty.tar.bz2'. Stop. ```
samueldr
force-pushed
the
fix/flakes-build
branch
from
3d74fe1
to
1e090b0
Compare
|
I guess this is because you're using |
|
Oh, weird, I tried a simpler "fix" at first, where I deleted I see, so flake knows about sources of dirt? What kind of sources of dirt are recognized by I'm fine with this not being merged in that case, feel free to close. I'll add filtering to the compatibility shim, but would like to know what kind of "dirt" is handled by flakes. |
samueldr
changed the title
|
I won't edit the comment, just in case, but I'm re-reading myself and I sure sound annoyed. I'm merely surprised, and curious to read about the change proper. |
|
It's actually the same behaviour as |
|
So you should be able to simulate the flake behaviour by doing something like |
Currently, from a git checkout, using
nix-buildfails like this forme:
As can be deduced from the two
No such file or directory, the fileslisting in
.dist-filesgets expanded once used bytar.The branch name is
mojave-$HOME.This is a dumb workaround rather than a proper fix.
Fixing this by escaping using
sedto double-up the$fails like this:And trying to escape it as
\$fails like this: