Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #80467 from danieldk/fix-python-vowpalwabbit #80467

Merged
merged 1 commit into from Feb 19, 2020
Merged

Merge pull request #80467 from danieldk/fix-python-vowpalwabbit #80467

merged 1 commit into from Feb 19, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change
  • Drop the Boost patch. The patch does not apply anymore and the new
    CMake infrastructure picks up boost.
  • Distable setuptools reStructuredText check. This check fails, but
    is (as far as I understand) an upstream bug.
  • Clean up derivation a bit.

ZHF #80379

I didn't check on Darwin yet. Maybe someone with the right grahamcofborg permissions could trigger a build. If it fails, I can probably check it on my MacBook tomorrow.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
python3Packages.vowpalwabbit: fix build
0688cba 
- Drop the Boost patch. The patch does not apply anymore and the new
  CMake infrastructure picks up boost.
- Distable setuptools reStructuredText check. This check fails, but
  is (as far as I understand) an upstream bug.
- Clean up derivation a bit.
@ofborg ofborg bot requested a review from teh February 18, 2020 20:04
@disassembler
Copy link
Member

@GrahamcOfBorg build python3Packages.vowpalwabbit

@disassembler disassembler changed the title python3Packages.vowpalwabbit: fix build Merge pull request #80467 from danieldk/fix-python-vowpalwabbit Feb 19, 2020
@disassembler disassembler merged commit 47ab49a into NixOS:master Feb 19, 2020
@danieldk danieldk deleted the fix-python-vowpalwabbit branch July 6, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@teh teh Awaiting requested review from teh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @disassembler