Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubyWithPackages.libv8: fix compilation #80470

Merged
merged 1 commit into from Feb 19, 2020
Merged

rubyWithPackages.libv8: fix compilation #80470

merged 1 commit into from Feb 19, 2020

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Feb 18, 2020 •
edited

Motivation for this change

This works around the removed option to build with a system libv8 that happened in rubyjs/libv8@c714ddf#diff-e4644139217623558c4f0b5fd4e07805 and uses the still existing code to simply hardcode the option for now.

This should be good enough for 20.03 but we'll probably have to find a more future-proof way to do this later.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ZHF: #80379
rubyPackages: update #76595

@alyssais @zimbatm

@disassembler disassembler merged commit 6152582 into NixOS:master Feb 19, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 20, 2020
@disassembler @dtzWill
rubyWithPackages.libv8: fix compilation (NixOS#80470)
b6472dd 
rubyWithPackages.libv8: fix compilation

(cherry picked from commit 6152582)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manveru @disassembler