Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.CPAN: apply patch to fix changed YAML module default #80471

Merged
merged 1 commit into from Feb 19, 2020
Merged

perlPackages.CPAN: apply patch to fix changed YAML module default #80471

merged 1 commit into from Feb 19, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Feb 18, 2020 •
edited

ZHF: #80379
https://hydra.nixos.org/build/112819370
https://hydra.nixos.org/build/112832567

A default has changed in YAML, breaking the latest release of CPAN. This commit
applies a patch from andk/cpanpm#133
fixing the problem.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp
perlPackages.CPAN: apply patch to fix changed YAML module default
153b0db 
ZHF: NixOS#80379
https://hydra.nixos.org/build/112819370
https://hydra.nixos.org/build/112832567

A default has changed in YAML, breaking the latest release of CPAN. This commit
applies a A patch from the PR fixing the problem.

andk/cpanpm#133
@stigtsp stigtsp closed this Feb 18, 2020
@stigtsp stigtsp deleted the package/perl-cpan-yaml-loadblessed-patch-zhf branch February 18, 2020 22:15
@stigtsp stigtsp restored the package/perl-cpan-yaml-loadblessed-patch-zhf branch February 18, 2020 22:16
@stigtsp stigtsp reopened this Feb 18, 2020
@veprbl
Copy link
Member

veprbl commented Feb 19, 2020

@GrahamcOfBorg perl528Packages.CPAN perl530Packages.CPAN

@veprbl
Copy link
Member

veprbl commented Feb 19, 2020

@GrahamcOfBorg build perl528Packages.CPAN perl530Packages.CPAN

@veprbl veprbl merged commit c5ce00d into NixOS:master Feb 19, 2020
veprbl pushed a commit that referenced this pull request Feb 19, 2020
@stigtsp @veprbl
perlPackages.CPAN: apply patch to fix changed YAML module default
8154fd4 
ZHF: #80379
https://hydra.nixos.org/build/112819370
https://hydra.nixos.org/build/112832567

A default has changed in YAML, breaking the latest release of CPAN. This commit
applies a A patch from the PR fixing the problem.

andk/cpanpm#133

(cherry picked from commit 153b0db)
cc #80471
@stigtsp stigtsp mentioned this pull request Mar 2, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @veprbl